Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[library usage] Move modules under pkg to pkg/internal #376

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

bcho
Copy link
Member

@bcho bcho commented Dec 18, 2023

This pull request is part of the changes for #373

In this pull request we moved most of the sub packages under pkg to pkg/internal except the pkg/cmd. The pkg/cmd is needed to be exported from pkg level as Go's internal package rule limit the internal package visibility level to pkg only. We also hid sub-commands from pkg/cmd to avoid unexpected references.

Now, the root level main function imports only pkg/cmd and it will be served as the sole entry point. This is slightly off from the design doc, but I believe the usage experience would be better as we allow user to install kubelogin via this:

$ go install github.com/Azure/kubelogin@{version}

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e83c88) 64.77% compared to head (659b526) 64.77%.

❗ Current head 659b526 differs from pull request most recent head bffc8a9. Consider uploading reports for the commit bffc8a9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   64.77%   64.77%           
=======================================
  Files          23       23           
  Lines        1766     1766           
=======================================
  Hits         1144     1144           
  Misses        549      549           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcho bcho marked this pull request as ready for review December 19, 2023 19:53
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit c6802f6 into master Dec 20, 2023
6 checks passed
@bcho bcho deleted the internal branch December 20, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants